use is_empty() instead of len() == x to determine if structs are empty. #69551

matthiaskrgr · 2020-02-28T14:06:21Z

No description provided.

Mark-Simulacrum

I almost want a "has_items()" but that seems like a pain to add, and shouldn't block this.

r=me with nit fixed

src/librustc_codegen_ssa/back/write.rs

Mark-Simulacrum · 2020-02-28T18:36:45Z

@bors r+ rollup

bors · 2020-02-28T18:36:46Z

📌 Commit 1622b6e has been approved by Mark-Simulacrum

@ghost

Rollup of 6 pull requests Successful merges: - #69477 (docs: add mention of async blocks in move keyword docs) - #69504 (Use assert_ne in hash tests) - #69546 (use to_vec() instead of .iter().cloned().collect() to convert slices to vecs.) - #69551 (use is_empty() instead of len() == x to determine if structs are empty.) - #69563 (Fix no_std detection for target triples) - #69567 (use .to_string() instead of format!() macro to create strings) Failed merges: r? @ghost

rust-highfive assigned ecstatic-morse Feb 28, 2020

use is_empty() instead of len() == x to determine if structs are empty.

9523c89

matthiaskrgr force-pushed the len_zero branch from 9e8c2d0 to 9523c89 Compare February 28, 2020 14:16

Mark-Simulacrum reviewed Feb 28, 2020

View reviewed changes

src/librustc_codegen_ssa/back/write.rs Outdated Show resolved Hide resolved

JohnTitor added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Feb 28, 2020

simplify condition in start_executing_work()

1622b6e

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 28, 2020

Dylan-DPC-zz mentioned this pull request Feb 29, 2020

Rollup of 6 pull requests #69570

Merged

bors merged commit c8db7dc into rust-lang:master Feb 29, 2020

matthiaskrgr deleted the len_zero branch February 29, 2020 14:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

use is_empty() instead of len() == x to determine if structs are empty. #69551

use is_empty() instead of len() == x to determine if structs are empty. #69551

matthiaskrgr commented Feb 28, 2020

Mark-Simulacrum left a comment

Mark-Simulacrum commented Feb 28, 2020

bors commented Feb 28, 2020

use is_empty() instead of len() == x to determine if structs are empty. #69551

use is_empty() instead of len() == x to determine if structs are empty. #69551

Conversation

matthiaskrgr commented Feb 28, 2020

Mark-Simulacrum left a comment

Choose a reason for hiding this comment

Mark-Simulacrum commented Feb 28, 2020

bors commented Feb 28, 2020